Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating AzureKeyVault task version #2313

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

FarrukhMasud
Copy link
Contributor

@FarrukhMasud FarrukhMasud commented Nov 12, 2024

Related Issues/PRs

AzureKeyVault task version has been deprecated and needs to be updated to the latest version. GitRelease task has also been deprecated. By updating these two tasks, we will get fewer warnings. It will reduce warnings from over 160 to about 60.

What changes are proposed in this pull request?

Updating task version to 1 from 0 for GitRelease and AzureKeyVault

How is this patch tested?

Pipeline change only.

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.

@FarrukhMasud
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (6796242) to head (5bc517c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2313      +/-   ##
==========================================
- Coverage   84.57%   84.51%   -0.07%     
==========================================
  Files         326      326              
  Lines       16769    16769              
  Branches     1480     1480              
==========================================
- Hits        14183    14172      -11     
- Misses       2586     2597      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FarrukhMasud
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FarrukhMasud
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit a360886 into microsoft:master Nov 13, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants